-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove codepaths for v1 meta API #5796
Conversation
🦋 Changeset detectedLatest commit: 8db4191 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Minor testing comment/question - wonder if we should be removing meta from tests that don't assert against it instead of migrating it v1 -> v2?
Looks good otherwise - just needs a changeset
integration/cf-compiler-test.ts
Outdated
export const meta = () => { | ||
return [{ title: "New Remix App" }]; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test doesn't seem like it's testing anything around meta
behavior - do we need to add this? Feels like it's just more surface area we'll need to update if/when we move to any eventual API beyond v2 meta
Closes: #
Testing Strategy: