Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codepaths for v1 meta API #5796

Merged
merged 20 commits into from
Mar 16, 2023
Merged

Remove codepaths for v1 meta API #5796

merged 20 commits into from
Mar 16, 2023

Conversation

chaance
Copy link
Collaborator

@chaance chaance commented Mar 14, 2023

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2023

🦋 Changeset detected

Latest commit: 8db4191

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Major
@remix-run/cloudflare Major
@remix-run/deno Major
@remix-run/dev Major
@remix-run/eslint-config Major
@remix-run/node Major
@remix-run/react Major
@remix-run/server-runtime Major
@remix-run/testing Major
@remix-run/cloudflare-pages Major
@remix-run/cloudflare-workers Major
create-remix Major
@remix-run/css-bundle Major
@remix-run/architect Major
@remix-run/express Major
@remix-run/netlify Major
@remix-run/vercel Major
@remix-run/serve Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chaance chaance changed the title remove codepaths for v1 meta API Remove codepaths for v1 meta API Mar 14, 2023
@chaance chaance marked this pull request as ready for review March 16, 2023 05:03
Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Minor testing comment/question - wonder if we should be removing meta from tests that don't assert against it instead of migrating it v1 -> v2?

Looks good otherwise - just needs a changeset

export const meta = () => {
return [{ title: "New Remix App" }];
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't seem like it's testing anything around meta behavior - do we need to add this? Feels like it's just more surface area we'll need to update if/when we move to any eventual API beyond v2 meta

@chaance chaance merged commit 114efc2 into v2 Mar 16, 2023
@chaance chaance deleted the chance/remove-v1-meta branch March 16, 2023 17:55
@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Jul 9, 2023
@MichaelDeBoey MichaelDeBoey added the v2 Issues related to v2 apis label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump CLA Signed v2 Issues related to v2 apis
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants