Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v2_normalizeFormMethod #5905

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Remove v2_normalizeFormMethod #5905

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9c4aaa
Remove v2_normalizeFormMethod
brophdawg11 Mar 24, 2023
fe3b775
Add changeset
brophdawg11 Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/hooks/use-navigation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ function SomeComponent() {
}
```

<docs-warning>The `useNavigation().formMethod` field is lowercase without the `future.v2_normalizeFormMethod` [Future Flag][api-development-strategy]. This is being normalized to uppercase to align with the `fetch()` behavior in v2, so please upgrade your Remix v1 applications to adopt the uppercase HTTP methods.</docs-warning>

<docs-info>For more information and usage, please refer to the [React Router `useNavigation` docs][rr-usenavigation].</docs-info>

[rr-usenavigation]: https://reactrouter.com/hooks/use-navigation
Expand Down
22 changes: 8 additions & 14 deletions docs/pages/api-development-strategy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,20 +51,14 @@ The lifecycle is thus either:

Here's the current future flags in Remix v1 today:

| Flag | Description |
| ------------------------------- | --------------------------------------------------------------------- |
| `unstable_cssModules` | Enable CSS Modules Support |
| `unstable_cssSideEffectImports` | Enable CSS Side Effect imports |
| `unstable_dev` | Enable the new development server (including HMR/HDR support) |
| `unstable_postcss` | Enable PostCSS Support |
| `unstable_tailwind` | Enable TailwindCSS support |
| `unstable_vanillaExtract` | Enable Vanilla Extract Support |
| `v2_errorBoundary` | Combine `ErrorBoundary`/`CatchBoundary` into a single `ErrorBoundary` |
| `v2_meta` | Enable the new API for your `meta` functions |
| `v2_normalizeFormMethod` | Normalize `useNavigation().formMethod` to be an uppercase HTTP Method |
| `v2_routeConvention` | Enable the flat routes style of file-based routing |

We're in the process of preparing for our v2 release, so all `future.unstable_` flags are being stabilized into `future.v2_` flags (except for those which are not breaking changes, like PostCSS/Tailwind/Vanilla Extract support). This includes adding deprecation warnings for apps still using the old way. Once we stabilize them all we'll do a final Remix 1.15.0 release and let that run for a bit to give folks time to opt into any flags they haven't yet added. Then we'll plan to release Remix 2.0.0 and start working on releasing flag-driven Remix v3 features.
Copy link
Contributor Author

@brophdawg11 brophdawg11 Mar 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all v2 flags from this branch since they're all gone now as well as this paragraph about 1.15.0/v2

| Flag | Description |
| ------------------------------- | ------------------------------------------------------------- |
| `unstable_cssModules` | Enable CSS Modules Support |
| `unstable_cssSideEffectImports` | Enable CSS Side Effect imports |
| `unstable_dev` | Enable the new development server (including HMR/HDR support) |
| `unstable_postcss` | Enable PostCSS Support |
| `unstable_tailwind` | Enable TailwindCSS support |
| `unstable_vanillaExtract` | Enable Vanilla Extract Support |

[future-flags-blog-post]: https://remix.run/blog/future-flags
[feature-flowchart]: /docs-images/feature-flowchart.png
14 changes: 7 additions & 7 deletions integration/navigation-state-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ test.describe("navigation states", () => {
state: null,
key: expect.any(String),
},
formMethod: "get",
formMethod: "GET",
formAction: `/${STATES.SUBMITTING_LOADER}`,
formEncType: "application/x-www-form-urlencoded",
formData: expect.any(Object),
Expand Down Expand Up @@ -310,7 +310,7 @@ test.describe("navigation states", () => {
state: null,
key: expect.any(String),
},
formMethod: "get",
formMethod: "GET",
formAction: `/${STATES.SUBMITTING_LOADER_REDIRECT}`,
formEncType: "application/x-www-form-urlencoded",
formData: expect.any(Object),
Expand All @@ -326,7 +326,7 @@ test.describe("navigation states", () => {
},
key: expect.any(String),
},
formMethod: "get",
formMethod: "GET",
formAction: `/${STATES.SUBMITTING_LOADER_REDIRECT}`,
formEncType: "application/x-www-form-urlencoded",
formData: expect.any(Object),
Expand Down Expand Up @@ -355,7 +355,7 @@ test.describe("navigation states", () => {
state: null,
key: expect.any(String),
},
formMethod: "post",
formMethod: "POST",
formAction: `/${STATES.SUBMITTING_ACTION}`,
formEncType: "application/x-www-form-urlencoded",
formData: expect.any(Object),
Expand All @@ -369,7 +369,7 @@ test.describe("navigation states", () => {
state: null,
key: expect.any(String),
},
formMethod: "post",
formMethod: "POST",
formAction: `/${STATES.SUBMITTING_ACTION}`,
formEncType: "application/x-www-form-urlencoded",
formData: expect.any(Object),
Expand Down Expand Up @@ -400,7 +400,7 @@ test.describe("navigation states", () => {
state: null,
key: expect.any(String),
},
formMethod: "post",
formMethod: "POST",
formAction: `/${STATES.SUBMITTING_ACTION_REDIRECT}`,
formEncType: "application/x-www-form-urlencoded",
formData: expect.any(Object),
Expand All @@ -416,7 +416,7 @@ test.describe("navigation states", () => {
},
key: expect.any(String),
},
formMethod: "post",
formMethod: "POST",
formAction: `/${STATES.SUBMITTING_ACTION_REDIRECT}`,
formEncType: "application/x-www-form-urlencoded",
formData: expect.any(Object),
Expand Down
Loading