fix(v2_meta): hint data as being potentially undefined

[machour]

I've been bitten by this in production a while ago, so here's my attempt at fixing it.

Not sure why we have duplicate types definitions in the react package, instead of a re-export from server-runtime.
Also, not sure this is the smartest fix, would definitely accept a better one

Closes: #6210

• Docs
• Tests

Testing Strategy:

Before	After

[changeset-bot]

🦋 Changeset detected

Latest commit: 2f658b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@remix-run/react	Patch
@remix-run/server-runtime	Patch
@remix-run/testing	Patch
@remix-run/cloudflare	Patch
@remix-run/deno	Patch
@remix-run/dev	Patch
@remix-run/node	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
create-remix	Patch
@remix-run/css-bundle	Patch
@remix-run/architect	Patch
@remix-run/express	Patch
@remix-run/netlify	Patch
@remix-run/serve	Patch
@remix-run/vercel	Patch
remix	Patch
@remix-run/eslint-config	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[aaronadamsCA]

Note this is a duplicate of #5787.

[machour]

Good catch @aaronadamsCA, thank you!

[kentcdodds]

I think this PR is actually better than #5787...

[machour]

Reopening for @brophdawg11 consideration.
I think that we both did half the job 😅

[brophdawg11]

yeah I like this one better too I think

[brophdawg11]

FWIW this should be a less common occurence now that #6107 is merged - it was a bug that we were still calling meta() for unrendered routes below the error boundary. But this is still needed if a loader throws to it's own boundary and we will still call meta().

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-d8bcdc1-20230506 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 1.16.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 1.16.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!