Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): gracefully handle hdr errors #6467

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented May 23, 2023

Fixes #6448

Introduces a step in the HMR/HDR integration test where invalid syntax is written to a route and then subsequently fixed. Dev server does not crash and correctly applies HMR/HDR when fix is written.

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2023

🦋 Changeset detected

Latest commit: 895c3db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori force-pushed the pedro/handle-hdr-errors branch from 006a4f8 to 3c921a5 Compare May 23, 2023 23:07
@pcattori pcattori linked an issue May 24, 2023 that may be closed by this pull request
1 task
@pcattori pcattori force-pushed the pedro/handle-hdr-errors branch from 3c921a5 to f1a165c Compare May 24, 2023 15:25
@pcattori pcattori force-pushed the pedro/handle-hdr-errors branch from f1a165c to 895c3db Compare May 24, 2023 15:25
@pcattori pcattori marked this pull request as ready for review May 24, 2023 15:26
@pcattori pcattori merged commit 9efdaea into dev May 24, 2023
@pcattori pcattori deleted the pedro/handle-hdr-errors branch May 24, 2023 15:58
19Qingfeng pushed a commit to 19Qingfeng/remix that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error crashes dev server in 1.16.1
1 participant