Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dev): reuse dev server port for websocket #6476

Merged
merged 8 commits into from
May 25, 2023
Merged

feat(dev): reuse dev server port for websocket #6476

merged 8 commits into from
May 25, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented May 24, 2023 •
edited
Loading

Fixes #6319 #6419

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 94b1dae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Minor
@remix-run/react Minor
@remix-run/server-runtime Minor
create-remix Minor
@remix-run/css-bundle Minor
@remix-run/testing Minor
@remix-run/cloudflare Minor
@remix-run/deno Minor
@remix-run/node Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/architect Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/serve Minor
@remix-run/vercel Minor
remix Minor
@remix-run/eslint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori force-pushed the pedro/dev-port branch 2 times, most recently from 1a61bd6 to 398c396 Compare May 24, 2023 19:18
This was linked to issues May 25, 2023
<LiveReload port={12345} /> doesn't change port #6319
Closed
Inconsistent casing for websocketPort option #6419
Closed
@pcattori pcattori marked this pull request as ready for review May 25, 2023 02:21
pcattori added 4 commits May 24, 2023 22:28
@pcattori
refactor(dev): rename scheme, host, port options
f987ed7 
`httpScheme`/`--http-scheme` -> `scheme`/`--scheme`
`httpHost`/`--http-host` -> `host`/`--host`
`httpPort`/`--http-port` -> `port`/`--port`
@pcattori
fix(dev): dev server port priority
d11a354 
1. <LiveReload port /> prop
2. `unstable_dev` `--port` flag
3. `unstable_dev.port` config option
4. REMIX_DEV_SERVER_WS_PORT env var (TODO: remove in v2)
5. default: 8002 (TODO: remove in v2)
@pcattori
refactor(dev): rename devHttpOrigin -> devOrigin
720b9b0
@pcattori
chore(dev): add changeset for new dev server options
94b1dae
@pcattori pcattori merged commit a1301ed into dev May 25, 2023
@pcattori pcattori deleted the pedro/dev-port branch May 25, 2023 02:57
19Qingfeng pushed a commit to 19Qingfeng/remix that referenced this pull request May 25, 2023
@pcattori @19Qingfeng
feat(dev): reuse dev server port for websocket (remix-run#6476)
883a389
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-33cc4c0-20230525 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

This was referenced Jun 2, 2023
Closed
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

🤖 Hello there,

We just published version 1.17.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Jun 6, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

🤖 Hello there,

We just published version 1.17.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent casing for websocketPort option <LiveReload port={12345} /> doesn't change port
1 participant
@pcattori