-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server-runtime): support Priority
Set-Cookie
attribute
#6770
Conversation
🦋 Changeset detectedLatest commit: 85c55ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @haines, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
I've rebased this to resolve conflicts - could someone please approve the workflows again? |
e104768
to
db86cb9
Compare
I've rebased this again to resolve conflicts - could someone please approve the workflows again? Is there anything blocking this getting merged? |
7fe37ed
to
b4cea55
Compare
I've rebased this again to resolve conflicts - could someone please approve the workflows again? Would love to get this merged please 🙏 |
8d2f4f8
to
c88bfd0
Compare
I've rebased again... @MichaelDeBoey any chance of shipping this please? |
Signed-off-by: Andrew Haines <andrew@haines.org.nz>
c88bfd0
to
2e89a94
Compare
Thanks 🎉 |
Thank you! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
This PR bumps the dependency on
cookie
to^0.5.0
in order to gain support for thePriority
Set-Cookie
attribute.cookie@0.5.0
also includes performance improvements and fixes theexpires
option to reject invalid dates (changelog).Testing Strategy:
This test covers this code