Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for scroll hash decoding #6788

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Add tests for scroll hash decoding #6788

merged 2 commits into from
Jul 12, 2023

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Jul 7, 2023 •
edited
Loading

Integration tests for remix-run/react-router#10642. These won't pass in CI until we do the next RR release and get Remix bumped.

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1662014

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 self-assigned this Jul 7, 2023
@brophdawg11 brophdawg11 added the feat:scroll Issues related to scroll restoration label Jul 10, 2023
@brophdawg11 brophdawg11 merged commit 6d72c6d into dev Jul 12, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/scroll-test branch July 12, 2023 14:33
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brophdawg11 brophdawg11

Labels
awaiting release This issue has been fixed and will be released soon CLA Signed feat:scroll Issues related to scroll restoration package:server-runtime package:testing renderer:react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brophdawg11 @MichaelDeBoey