Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add second generic to UIMatch for handle field #7464

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Add second generic to UIMatch for handle field #7464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/add-uimatch-handle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/react": patch
---

Add second generic to `UIMatch` for `handle` field
6 changes: 5 additions & 1 deletion packages/remix-react/components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ import type {
MetaDescriptor,
MetaMatch,
MetaMatches,
RouteHandle,
} from "./routeModules";

function useDataRouterContext() {
Expand Down Expand Up @@ -976,7 +977,10 @@ function dedupe(array: any[]) {
return [...new Set(array)];
}

export type UIMatch<D = AppData> = UIMatchRR<SerializeFrom<D>>;
export type UIMatch<D = AppData, H = RouteHandle> = UIMatchRR<
SerializeFrom<D>,
H
>;

/**
* Returns the active route matches, useful for accessing loaderData for
Expand Down