Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-serve): in manual mode, watch for changes to version.txt instead of server build #7470

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Sep 18, 2023

to avoid race conditions caused by partially written server build

Tried HMR updates on a fresh install w/ these changes added in via LOCAL_BUILD_DIRECTORY

to avoid race conditions caused by partially written server build
@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023

🦋 Changeset detected

Latest commit: 7872b40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/serve Patch
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori merged commit 19d66ed into dev Sep 18, 2023
5 checks passed
@pcattori pcattori deleted the pedro/remix-serve-watch-version branch September 18, 2023 16:39
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Sep 18, 2023
@MichaelDeBoey MichaelDeBoey changed the title in manual mode, watch for changes to version.txt instead of server build feat(remix-serve): in manual mode, watch for changes to version.txt instead of server build Sep 18, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-fccadba-20230919 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants