Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): deduplicate @remix-run/react #7926

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Nov 7, 2023

Fixes #7914

Testing strategy

Cloned npm reproduction and built Remix into repro locally via LOCAL_BUILD_DIRECTORY and ran with vite dev --force.

Also, removed optimizeDeps.include from integration tests since that's no longer needed.

Copy link

changeset-bot bot commented Nov 7, 2023

🦋 Changeset detected

Latest commit: b8ce49b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori force-pushed the pedro/vite-dedupe-remix-router branch from 218e686 to b8ce49b Compare November 7, 2023 03:23
@pcattori pcattori merged commit b6b2857 into dev Nov 7, 2023
9 checks passed
@pcattori pcattori deleted the pedro/vite-dedupe-remix-router branch November 7, 2023 03:44
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Nov 7, 2023
Copy link
Contributor

🤖 Hello there,

We just published version 2.3.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.3.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant