Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): load .env files into process.env in dev #7958

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

markdalgleish
Copy link
Member

Fixes #7934

Copy link

changeset-bot bot commented Nov 10, 2023

🦋 Changeset detected

Latest commit: c6cfa88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit bf2feb9 into dev Nov 10, 2023
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/vite-dotenv branch November 10, 2023 19:21
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Nov 10, 2023
Copy link
Contributor

🤖 Hello there,

We just published version 2.3.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.3.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Nov 16, 2023
@JacobMGEvans
Copy link

Hey! I love this, we came across this https://discord.com/channels/856971667393609759/1171477346046447616

seems like the backend code is not reading the Secret key properly in some situations.
https://github.com/JacobMGEvans/remix-and-vite-repro
Repro routes:
http://localhost/:5173/working
http://localhost/:5173/not-working

@markdalgleish
Copy link
Member Author

markdalgleish commented Nov 16, 2023

@JacobMGEvans You should be using process.env on the server rather than import.meta.env. In Remix I'd recommend avoiding import.meta.env entirely since it bakes the environment variables into the code rather than allowing them to be dynamic at runtime. Instead you should use process.env on the server, and if the client needs access to it, pass the required env vars to the client via the loader.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants