Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev/vite): add Vite commands to dev CLI #8211

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Dec 4, 2023

This PR adds remix vite:dev and remix vite:build commands to the Remix CLI. We may want to bikeshed these commands, but I personally like this format.

Note, this is an alternative, less-clever solution to #8206.

The advantages of this approach:

  • Again, it's less clever, which is a good thing.
  • It's closer to how people expect it to work.
  • There's no "uncanny valley" effect where the Vite CLI exposes options that don't make sense (and probably don't work correctly) if a plugin kicks off multiple builds internally (e.g. --watch, --profile, etc.), which also means consumers can't trust the Vite CLI docs anymore when using Remix. This is a pretty big knock against fix(remix-dev/vite): start SSR build within plugin #8206.

The disadvantage is that we're further away from being "just a Vite plugin", but if you look at how the build process works in this PR, you can see we're still using the Vite plugin as the source of truth for our build config even when running multiple builds. I think this is a pretty nice hybrid since you don't need a dedicated Remix config. In fact vite build && vite build --ssr still works, it just won't be guaranteed to work with different plugin configurations in the future.

Copy link

changeset-bot bot commented Dec 4, 2023

🦋 Changeset detected

Latest commit: 4f62666

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit 48cde3b into dev Dec 5, 2023
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/wrap-vite-commands branch December 5, 2023 22:58
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

🤖 Hello there,

We just published version 2.4.0-pre.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Dec 8, 2023

🤖 Hello there,

We just published version 2.4.0-pre.7 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.4.0-pre.9 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.4.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.4.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants