-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-dev/vite): add Vite commands to dev CLI #8211
Conversation
🦋 Changeset detectedLatest commit: 4f62666 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
This PR adds
remix vite:dev
andremix vite:build
commands to the Remix CLI. We may want to bikeshed these commands, but I personally like this format.Note, this is an alternative, less-clever solution to #8206.
The advantages of this approach:
--watch
,--profile
, etc.), which also means consumers can't trust the Vite CLI docs anymore when using Remix. This is a pretty big knock against fix(remix-dev/vite): start SSR build within plugin #8206.The disadvantage is that we're further away from being "just a Vite plugin", but if you look at how the build process works in this PR, you can see we're still using the Vite plugin as the source of truth for our build config even when running multiple builds. I think this is a pretty nice hybrid since you don't need a dedicated Remix config. In fact
vite build && vite build --ssr
still works, it just won't be guaranteed to work with different plugin configurations in the future.