Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Move SSR-only CSS files to client build #8796

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

markdalgleish
Copy link
Member

Fixes #8786.

We already had a similar test for generic assets using a .txt import, but .css?url imports need to be handled separately, so I've added another test case for this.

Copy link

changeset-bot bot commented Feb 19, 2024

🦋 Changeset detected

Latest commit: 306b955

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori merged commit ca9c9f2 into release-next Feb 19, 2024
9 checks passed
@pcattori pcattori deleted the markdalgleish/ssr-only-css-files branch February 19, 2024 23:31
Copy link
Contributor

🤖 Hello there,

We just published version 2.7.0-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.7.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants