Vite: Fix build.sourcemap
config support
#8965
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8935
The Remix CLI was defaulting
build.sourcemap
tofalse
in the inline Vite config object passed tovite.build
, but this was taking higher precedence thanbuild.sourcemap
in the user's Vite config. This meant that the only way to generate sourcemaps was via the--sourcemapServer
and--sourcemapClient
CLI flags. To avoid this, we need to default the values for these options toundefined
rather thanfalse
.