Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Fix build.sourcemap config support #8965

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Mar 3, 2024

Fixes #8935

The Remix CLI was defaulting build.sourcemap to false in the inline Vite config object passed to vite.build, but this was taking higher precedence than build.sourcemap in the user's Vite config. This meant that the only way to generate sourcemaps was via the --sourcemapServer and --sourcemapClient CLI flags. To avoid this, we need to default the values for these options to undefined rather than false.

Copy link

changeset-bot bot commented Mar 3, 2024

🦋 Changeset detected

Latest commit: d7b12d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit 0fff72f into dev Mar 4, 2024
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/fix-build-sourcemap-option branch March 4, 2024 00:23
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

🤖 Hello there,

We just published version 2.8.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Mar 7, 2024

🤖 Hello there,

We just published version 2.8.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant