Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix single fetch redirects whena basename is present #9848

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Fix single fetch redirects whena basename is present #9848

merged 2 commits into from
Aug 9, 2024

Conversation

brophdawg11
Copy link
Contributor

Closes #9586

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b814483

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/server-runtime Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/testing Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/serve Patch
create-remix Patch
remix Patch
@remix-run/css-bundle Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Aug 9, 2024 that may be closed by this pull request
Single Fetch: redirects do not strip basename #9586
Closed
@brophdawg11 brophdawg11 force-pushed the brophdawg11/single-fetch-basename-redirect branch 3 times, most recently from 8ed5917 to abf5f72 Compare August 9, 2024 18:45
@brophdawg11 brophdawg11 force-pushed the brophdawg11/single-fetch-basename-redirect branch from abf5f72 to aec262c Compare August 9, 2024 18:47
@brophdawg11 brophdawg11 merged commit 05bb290 into dev Aug 9, 2024
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/single-fetch-basename-redirect branch August 9, 2024 19:09
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 9, 2024
@brophdawg11 brophdawg11 mentioned this pull request Aug 9, 2024
Closed
@github-actions github-actions bot mentioned this pull request Aug 14, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.11.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Aug 15, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.11.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-ebey jacob-ebey jacob-ebey approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single Fetch: redirects do not strip basename
2 participants
@brophdawg11 @jacob-ebey