#648 added comment on some trade-offs and TBD items if we want to sup…

…port capturing multi-char values in char[] types for non-interactive options
remkop · May 3, 2019 · 79073c8 · 79073c8
1 parent c9d53f6
commit 79073c8
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/main/java/picocli/CommandLine.java b/src/main/java/picocli/CommandLine.java
@@ -10739,6 +10739,10 @@ private Collection<Object> createCollection(Class<?> collectionClass, Class<?> e
         }
         private ITypeConverter<?> getTypeConverter(final Class<?> type, ArgSpec argSpec, int index) {
             if (argSpec.converters().length > index) { return argSpec.converters()[index]; }
+            // https://github.com/remkop/picocli/pull/648
+            // consider adding ParserSpec.charArraysCanCaptureStrings() to allow non-interactive options to capture multi-char values in a char[] array
+            // Note that this will require special logic for char[] types in CommandLine$Interpreter.applyValuesToArrayField;
+            // TBD: what to do with multiple values? Append or overwrite?
             if (char[].class.equals(argSpec.type()) && argSpec.interactive()) { return converterRegistry.get(char[].class); }
             if (converterRegistry.containsKey(type)) { return converterRegistry.get(type); }
             if (type.isEnum()) {