Skip to content

Commit

Permalink
[BUILD] bugfix in module inclusion conditions
Browse files Browse the repository at this point in the history
  • Loading branch information
remkop committed Feb 6, 2023
1 parent 850dab2 commit e3dbca4
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,15 @@ include 'picocli-codegen'
if (org.gradle.api.JavaVersion.current().isJava8Compatible()) {
include 'picocli-spring-boot-starter'
include 'picocli-shell-jline3'
} else if (org.gradle.api.JavaVersion.current().isJava9Compatible()) {
} else {
println("Excluding modules picocli-spring-boot-starter, picocli-shell-jline3: " +
"they require Java 8+ but we have Java version ${org.gradle.api.JavaVersion.current()}")
}
if (org.gradle.api.JavaVersion.current().isJava9Compatible()) {
include 'picocli-codegen-tests-java8plus'
include 'picocli-tests-java8plus'
} else {
println("Excluding modules picocli-codegen-tests-java8plus, " +
"picocli-spring-boot-starter, picocli-shell-jline3, and " +
"picocli-tests-java8plus from the build: " +
"they require Java 8 or 9 but we have Java version ${org.gradle.api.JavaVersion.current()}")
"they require Java 8 9 but we have Java version ${org.gradle.api.JavaVersion.current()}")
}

This comment has been minimized.

Copy link
@deining

deining Feb 6, 2023

Contributor

they require Java 8 9 ...

Is this intended? Shouldn't that be:

they require Java 9+ ...

1 comment on commit e3dbca4

@remkop
Copy link
Owner Author

@remkop remkop commented on e3dbca4 Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are correct! Thank you, will fix soon.

Please sign in to comment.