Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picocli should only use Java 5 API #1045

Closed
remkop opened this issue May 14, 2020 · 1 comment
Closed

Picocli should only use Java 5 API #1045

remkop opened this issue May 14, 2020 · 1 comment
Labels
theme: usagehelp An issue or change related to the usage help message type: bug 🐛
Milestone
4.3.1

Comments

@remkop
Copy link
Owner

remkop commented May 14, 2020

As part of the work for #765, a call to String.isEmpty was introduced in DefaultParamLabelRenderer.renderParameterLabel.

The String.isEmpty method was introduced in Java 6. Picocli code should call the equivalent internal method instead.
@remkop remkop added type: bug 🐛 theme: usagehelp An issue or change related to the usage help message labels May 14, 2020
@remkop remkop added this to the 4.3.1 milestone May 14, 2020
@remkop
Copy link
Owner Author

remkop commented May 14, 2020

Fixed in commit d176753.

@remkop remkop closed this as completed May 14, 2020
remkop added a commit that referenced this issue May 14, 2020
@remkop
[#1045] update release notes
da8455b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme: usagehelp An issue or change related to the usage help message type: bug 🐛
Projects
None yet
Milestone
4.3.1
Development

No branches or pull requests
1 participant
@remkop