Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle Module Metadata for picocli 4.4.0+ missing from Maven Central #1152

Closed
fpavageau opened this issue Aug 24, 2020 · 3 comments
Closed
Labels
theme: module An issue or change related to JPMS modules type: bug 🐛
Milestone

Comments

@fpavageau
Copy link

picocli-4.4.0.pom was generated with the following comment

<!--  This module was also published with a richer model, Gradle metadata,   -->
<!--  which should be used instead. Do not delete the following line which   -->
<!--  is to indicate to Gradle or any Gradle module metadata file consumer   -->
<!--  that they should prefer consuming it instead.  -->
<!--  do_not_remove: published-with-gradle-metadata  -->

which triggers the download by Gradle of the picocli-4.4.0.module artifact, however that artifact was not published to Maven Central. This is probably a consequence of the upgrade to Gradle 6 in 98dc696.

This is a problem when using Artifactory as a Maven proxy, because by default Artifactory returns a 403 HTTP status code for missing artifacts, and Gradle only ignores an absent .module when the repository returns a 404 HTTP status code. In my case (and others, probably), that means my build fails when it cannot download picocli-4.4.0.module. 😭

See rsocket/rsocket-java#746 for a similar issue in another project (resolved by rsocket/rsocket-java#751).

@remkop
Copy link
Owner

remkop commented Aug 24, 2020

Ouch! I wasn’t aware of this, thanks for letting me know!

I’ll probably use the same fix: disable the feature for now.

@remkop remkop added type: bug 🐛 theme: module An issue or change related to JPMS modules labels Aug 24, 2020
@remkop remkop added this to the 4.6 milestone Aug 24, 2020
@remkop remkop closed this as completed in 0874760 Aug 24, 2020
@remkop
Copy link
Owner

remkop commented Aug 24, 2020

I pushed a change that fixes the issue (disables generation of the picocli-4.4.0.module artifact).
I will do a release for this as soon as possible.

@remkop remkop modified the milestones: 4.6, 4.5.1 Aug 25, 2020
@remkop
Copy link
Owner

remkop commented Aug 26, 2020

Picocli 4.5.1 has been released. This should fix the issue.

Don't forget to star ⭐ picocli on GitHub if you like the project! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: module An issue or change related to JPMS modules type: bug 🐛
Projects
None yet
Development

No branches or pull requests

2 participants