Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picocli-4.6.0.jar requires groovy for OSGi but not for Maven #1329

Closed
Fiouz opened this issue Feb 20, 2021 · 3 comments
Closed

picocli-4.6.0.jar requires groovy for OSGi but not for Maven #1329

Fiouz opened this issue Feb 20, 2021 · 3 comments
Labels
theme: build An issue or change related to the build system type: bug 🐛
Milestone

Comments

@Fiouz
Copy link
Contributor

Fiouz commented Feb 20, 2021

Since 4.6.0, the META-INF/MANIFEST.MF file of the main artifact contains the following line:

Import-Package: groovy.lang

This does not seem correct as there is a dedicated artifact for Groovy support, and, since it does not match the pom.xml definition, it confuses consumers that rely on the POM definition to construct their OSGi repository:

org.osgi.framework.BundleException: Unable to resolve picocli [3](R 3.0): missing requirement [picocli [3](R 3.0)] osgi.wiring.package; (osgi.wiring.package=groovy.lang) Unresolved requirements: [[picocli [3](R 3.0)] osgi.wiring.package; (osgi.wiring.package=groovy.lang)]
	at org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4368)
	at org.apache.felix.framework.Felix.startBundle(Felix.java:2281)
	at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998)
	at aQute.launcher.Launcher.start(Launcher.java:674)
	at aQute.launcher.Launcher.startBundles(Launcher.java:654)
	at aQute.launcher.Launcher.activate(Launcher.java:560)
	at aQute.launcher.Launcher.launch(Launcher.java:400)
	at aQute.launcher.Launcher.run(Launcher.java:181)
	at aQute.launcher.Launcher.main(Launcher.java:157)
	at aQute.launcher.pre.EmbeddedLauncher.executeWithRunPath(EmbeddedLauncher.java:170)
	at aQute.launcher.pre.EmbeddedLauncher.findAndExecute(EmbeddedLauncher.java:135)
	at aQute.launcher.pre.EmbeddedLauncher.main(EmbeddedLauncher.java:52)

https://docs.osgi.org/specification/osgi.core/7.0.0/framework.module.html#framework.module.importpackage

@remkop remkop added type: bug 🐛 theme: build An issue or change related to the build system labels Feb 20, 2021
@remkop
Copy link
Owner

remkop commented Feb 20, 2021

@Fiouz Thank you for raising this!

I pushed a fix that I believe fixes the issue. Can you verify?

@Fiouz
Copy link
Contributor Author

Fiouz commented Feb 21, 2021

The change on the current master branch fixes the issue, thank you.

@remkop remkop added this to the 4.7 milestone Feb 21, 2021
@remkop
Copy link
Owner

remkop commented Feb 21, 2021

Thank you for the confirmation!
And thank you again for raising this! 🙏

@remkop remkop closed this as completed Feb 21, 2021
@remkop remkop modified the milestones: 4.7, 4.6.2 Feb 23, 2021
MarkoMackic pushed a commit to MarkoMackic/picocli that referenced this issue Oct 17, 2021
MarkoMackic added a commit to MarkoMackic/picocli that referenced this issue Oct 17, 2021
… should not require groovy"

This reverts commit ab03e80.
MarkoMackic added a commit to MarkoMackic/picocli that referenced this issue Oct 17, 2021
… should not require groovy"

This reverts commit ab03e80.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: build An issue or change related to the build system type: bug 🐛
Projects
None yet
Development

No branches or pull requests

2 participants