Missing GPL v2 + CPE license

[kswartz26]

Our company has been using this code for a while, and we recently noticed that it contains some code under GPL v2 with Classpath Exception (https://github.com/remkop/picocli/blob/master/docs/apidocs/search.js), but we can't find a copy of that license accompanying the project. Can you please add one, either as a separate file or in a NOTICE file?

Thanks!

[remkop]

Hi @kswartz26 thank you for raising this.

Will you be able to provide a pull request for this?

[kswartz26]

Hopefully that will do it.

[remkop]

Thank you for the contribution! Much appreciated.

[harbulot]

I can't speak as a legal expert, but using the GPL in an Apache License NOTICE file seems problematic.

It seems that GPL portion is only affecting the Javadoc output of the project, not so much the library source/binary itself. I'd generally expect the LICENSE/NOTICE files to mainly relate to the actual library code (and it's also quite common for projects to have a separate license for the documentation anyway).

It might be worth separating that, and having somewhere else than LICENSE/NOTICE instead, to make clear that the library itself is not under GPL (assuming the rest of the code doesn't have GPL inclusions, I haven't fully checked).

[remkop]

@harbulot Yes that makes sense.

I will probably rename the NOTICE file to NOTICE-DOCUMENTATION, and clarify that the file in question that is under the GPL is docs/apidocs/search.js.

I will also clarify that this file is not in any binary distribution and is only included in source code distributions that include the documentation.

[harbulot]

@remkop Great, thank you.

[remkop]

@harbulot I created #1750 for this.