ParameterException: NullPointerException: null while processing argument at or before arg[0] (was: commandLine.parseArgs("--item="); and commandLine.parseArgs("--item", ""); should behave identically, but current; they don't)
#1998
Labels
Milestone
Comments
AnalysisThis looks like a regression introduced in 4.7.2. // CommandLine.java L14551-14558
String fallback = consumed == 0 && argSpec.isOption() && !OptionSpec.DEFAULT_FALLBACK_VALUE.equals(((OptionSpec) argSpec).fallbackValue())
? ((OptionSpec) argSpec).fallbackValue()
: null;
boolean hasFallback = fallback != null || (argSpec.isOption() && Option.NULL_VALUE.equals(((OptionSpec) argSpec).originalFallbackValue));
if (hasFallback && (args.isEmpty() || !varargCanConsumeNextValue(argSpec, args.peek())
|| (!canConsumeOneArgument(argSpec, lookBehind, alreadyUnquoted, arity, consumed, args.peek(), argDescription)))) {
args.push(fallback);
}Should be: String fallback = argSpec.isOption() && !OptionSpec.DEFAULT_FALLBACK_VALUE.equals(((OptionSpec) argSpec).fallbackValue())
? ((OptionSpec) argSpec).fallbackValue()
: null;
boolean hasFallback = fallback != null || (argSpec.isOption() && Option.NULL_VALUE.equals(((OptionSpec) argSpec).originalFallbackValue));
if (consumed == 0 && hasFallback && (args.isEmpty() || !varargCanConsumeNextValue(argSpec, args.peek())
|| (!canConsumeOneArgument(argSpec, lookBehind, alreadyUnquoted, arity, consumed, args.peek(), argDescription)))) {
args.push(fallback);
}The issue is that the current code uses |
remkop
changed the title
commandLine.parseArgs("--item="); and commandLine.parseArgs("--item", ""); should behave identically, but current; they don'tcommandLine.parseArgs("--item="); and commandLine.parseArgs("--item", ""); should behave identically, but current; they don't)
remkop
added a commit
that referenced
this issue
Apr 16, 2023
…processing argument at or before arg[0]
remkop
added a commit
that referenced
this issue
Apr 16, 2023
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've been wanting to remove my own Converter now that #1993 is implemented, but I found that there is a difference in behavior when I use the converter and when I do not use it.
--itemin the reproducer below does not use converter (and does not pass one of the tests, while--item2uses converter and both tests pass.What I need to accomplish is that
commandLine.parseArgs("--item=", "--item", "pepa");parses into["", "pepa"], but actually, the parsing throws an exception (see bottom of the post for the printout).I can get the desired behavior when I specify the argument as
commandLine.parseArgs("--item", "");, but I do need to support the former syntax with the=as well.See
void test_item__empty_equals() {which is the failing test.Exception from
test_item__empty_equals()Logs are
The text was updated successfully, but these errors were encountered: