Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subcommands are not parsed when usageHelp = true and required param is missing #244

Closed
mkavanagh opened this issue Nov 28, 2017 · 2 comments
Milestone

Comments

@mkavanagh
Copy link

I'm implementing a CLI where the top-level command has two params (a required = true param and a usageHelp = true param), plus a number of subcommands

When the command is parsed with the required param missing and the usageHelp param supplied, I can check isUsageHelpRequested and print the usage for the top level command

When a subcommand is included I have to either:

remkop added a commit that referenced this issue Nov 28, 2017
…geHelp and versionHelp to determine if missing required options can be ignored when encountering a subcommand
@remkop
Copy link
Owner

remkop commented Nov 28, 2017

Thank you for reporting this!

I've fixed the issue in master. I will roll a release for this as soon as possible, hopefully within 24 hours.

@remkop remkop added this to the 2.1.0 milestone Nov 28, 2017
@remkop remkop closed this as completed in 0124e23 Nov 29, 2017
@remkop
Copy link
Owner

remkop commented Nov 29, 2017

Version 2.1.0 has been released. Thanks again for the bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants