-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completion scripts have redundant case statement #470
Comments
This also seems to make competition of short options with an argument not complete correctly, although the long option version work. |
I am a bit worried about regressions, so I want to test this one extra carefully but otherwise no objections. |
It will fix the option argument handling, which I believe was a pre-existing bug. I have a pull request ready, but it's on top of #469. |
I didn't see any regressions, but the following behavior is improved:
Then, |
…short options with arguments (generate completions)
Confirmed and merged. Nice work! |
I believe that we can simplify the competition scripts by using one case statement instead of two without losing any functionality. Replace:
with
The text was updated successfully, but these errors were encountered: