AutoComplete fails if using a custom IFactory implementation even if provided with --factory

[quinn-harper]

Our structure is as follows:

Class (command)

- Main.class (main)
  -- Sub.class (main sub)
    --- Sub$Command1.class (main sub com1)
    --- Sub$Command2.class (main sub com2)

All subcommands are declared in the @Command annotation.

When running the AutoComplete command to generate the file we get a stack trace with error:

Cannot instantiate subcommand package.Sub$Command1: the class has no constructor
Caused by: java.lang.NoSuchMethodException:package.Sub$Command1.<init>()

• This class has one constructor with parameters annotated with @Inject.
• We use our own implementation of IFactory we've passed to the command with --factory.
• The Main.class is the command we're trying to generate the autocompletion script for.

It seems like the problem is that the CommandLine implementation that is created by the AutoComplete command does not use the factory passed to it.

See:

picocli/src/main/java/picocli/AutoComplete.java

Lines 134 to 140 in 82f7c75

	IFactory factory = CommandLine.defaultFactory();
	if (factoryClass != null) {
	factory = (IFactory) factory.create(Class.forName(factoryClass));
	}
	Class<?> cls = Class.forName(commandLineFQCN);
	Object instance = factory.create(cls);
	CommandLine commandLine = new CommandLine(instance);

I've built picocli locally changing this line:

-CommandLine commandLine = new CommandLine(instance);
+CommandLine commandLine = new CommandLine(instance, factory);

This resolved the issue for us and I will create a pull request for it soon. Let me know if I'm missing any side effects this change may produce that require testing.

[remkop]

Good catch!

[remkop]

The PR has been merged. Thanks a lot!