Make CommandLine in AutoComplete use correct IFactory implementation #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases using the DefaultFactory when instantiating CommandLine could cause subcommands that require a specific IFactory implementation to fail to be created. This commit makes the CommandLine instance created by AutoComplete command use the IFactory passed to the command (if any).
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
=========================================
Coverage 98.24% 98.24%
Complexity 361 361
=========================================
Files 4 4
Lines 4106 4106
Branches 1010 1010
=========================================
Hits 4034 4034
Misses 17 17
Partials 55 55
Continue to review full report at Codecov.
|
remkop
added
type: enhancement ✨
theme: auto-completion
|
Merged into master. |
remkop
added a commit
that referenced
this pull request
Jan 17, 2019
…plete use correct IFactory implementation
|
Updated the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases using the DefaultFactory when instantiating CommandLine could cause subcommands that require a specific implementation to fail to be created. This commit makes the CommandLine instance use the IFactory implementation passed by the user to the AutoComplete command (if any) which should resolve this issue.
Closes #601