-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argument groups ignored in mixins (was: Heading section ignored when used inside mixins) #776
Comments
Thank you for the bug report and for the code to reproduce the issue. |
Update: the problem is bigger than just the headers: it turns out that the logic for importing mixin elements does not take argument groups into account at all. Only the options and positional parameters are mixed in, but the argument group information is ignored. This is an oversight, not by design. I'm looking now at how to address this. Side note: picocli does not add a newline after section headings. You may want to add a |
@teoincontatto Thank you again for raising this! |
Hi @remkop, glad to help picocli to get better with my 2 cents. Sorry for not being able to test the master branch with my code base. I'll try it out this monday hopefully. Regards |
Great! The easiest way to do this is to check out the project in git, then run After that you can use the |
I was able to pass the simple test using the 4.0.2-SNAPSHOT version. Now I am facing a
Since this seem to be unrelated to the original issue let me know if you want me to open a new one. |
If I do not use mixin then the result (with version 4.0.1 and 4.0.2-SNAPSHOT) is not trowing exception but it prints the nested options outside of the section in the help:
|
@teoincontatto Thanks a lot for finding more issues in this area! |
Something strange: |
You right, I've mixed code and output with another test I did, I correct the code and output with the correct ones in the previous message. In any case I'll open separates issues with corrected source and output. |
@teoincontatto Thank you for raising separate tickets for the new issues. I have fixed (hopefully) #779, and provided some feedback on #778. Let's continue the discussion on the respective tickets. About the original problem here (Argument groups ignored in mixins), I think that has also been fixed. Are you okay to close this ticket? |
Yes seems resolved. |
Thanks for the confirmation! |
I am not sure if this is expected behaviour or a bug but here it goes.
When I declare some heading section to show in the help using a mixin those sections does not appear:
Removing the mixin and defining the options directly in the command has the expected result:
The text was updated successfully, but these errors were encountered: