Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the expanded argument list from ParseResult #1075

Merged
merged 1 commit into from
May 27, 2020

Conversation

mashlol
Copy link
Contributor

@mashlol mashlol commented May 26, 2020

Written to solve #1074 , this exposes the expanded argument list that picocli keeps internally. I had to reverse the list since it was stored as a stack, which I believe means we're copying the full argument list twice into memory. Ideally we'd use some sort of reversed view and not duplicate it, but since we don't have guava or anything like that it's slightly ugly imo. Happy to update with that though.

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #1075 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1075   +/-   ##
=========================================
  Coverage     94.45%   94.46%           
  Complexity      448      448           
=========================================
  Files             2        2           
  Lines          6564     6571    +7     
  Branches       1765     1765           
=========================================
+ Hits           6200     6207    +7     
  Misses           93       93           
  Partials        271      271           
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 94.31% <100.00%> (+<0.01%) 309.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1415ba2...4fb1294. Read the comment docs.

@remkop remkop merged commit 396ddde into remkop:master May 27, 2020
@remkop remkop added this to the 4.4 milestone May 27, 2020
@remkop remkop added type: API 🔌 theme: parser An issue or change related to the parser labels May 27, 2020
remkop added a commit that referenced this pull request May 27, 2020
@remkop
Copy link
Owner

remkop commented May 27, 2020

Merged into master.
Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: parser An issue or change related to the parser type: API 🔌
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants