Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add tabs with Kotlin code for samples (manual chapter 10: Validation) #1223

Merged
merged 1 commit into from
Oct 23, 2020
Merged

DOC: add tabs with Kotlin code for samples (manual chapter 10: Validation) #1223

merged 1 commit into from
Oct 23, 2020

Conversation

deining
Copy link
Contributor

@deining deining commented Oct 22, 2020

No description provided.

@deining deining changed the title [#1222] DOC: add tabs with Kotlin code for samples (manual chapter 10… DOC: add tabs with Kotlin code for samples (manual chapter 10: Validation) Oct 22, 2020
Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR!

Let me know what you think about the idea to leave out the implements Runnable from SingleOptionValidationExample to keep it as small as possible.

docs/index.adoc Outdated
----
class SingleOptionValidationExample {
class SingleOptionValidationExample implements Runnable {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking to leave out the implements Runnable. The main point of this example is that apps can use an @Option-annotated method to do validation.

I think it is okay to for some examples to be fragments (as opposed to a fully executable program). Sometimes that helps to keep the example focused and communicates the point better.

docs/index.adoc Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #1223 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1223   +/-   ##
=========================================
  Coverage     94.33%   94.33%           
  Complexity      455      455           
=========================================
  Files             2        2           
  Lines          6676     6676           
  Branches       1796     1796           
=========================================
  Hits           6298     6298           
  Misses          102      102           
  Partials        276      276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9755a8...244ed85. Read the comment docs.

@deining deining requested a review from remkop October 23, 2020 05:35
Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@remkop remkop merged commit 6c350a4 into remkop:master Oct 23, 2020
@deining deining deleted the kotlin-code-samples branch October 23, 2020 06:13
remkop added a commit that referenced this pull request Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants