-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: add tabs with Kotlin code for samples (manual chapter 10: Validation) #1223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR!
Let me know what you think about the idea to leave out the implements Runnable
from SingleOptionValidationExample
to keep it as small as possible.
docs/index.adoc
Outdated
---- | ||
class SingleOptionValidationExample { | ||
class SingleOptionValidationExample implements Runnable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking to leave out the implements Runnable
. The main point of this example is that apps can use an @Option
-annotated method to do validation.
I think it is okay to for some examples to be fragments (as opposed to a fully executable program). Sometimes that helps to keep the example focused and communicates the point better.
Codecov Report
@@ Coverage Diff @@
## master #1223 +/- ##
=========================================
Coverage 94.33% 94.33%
Complexity 455 455
=========================================
Files 2 2
Lines 6676 6676
Branches 1796 1796
=========================================
Hits 6298 6298
Misses 102 102
Partials 276 276 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
No description provided.