Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User manual: update DI section on Quarkus (#1235) #1238

Merged
merged 1 commit into from
Oct 30, 2020
Merged

User manual: update DI section on Quarkus (#1235) #1238

merged 1 commit into from
Oct 30, 2020

Conversation

deining
Copy link
Contributor

@deining deining commented Oct 29, 2020

No description provided.

@remkop
Copy link
Owner

remkop commented Oct 29, 2020

Wow, this is great!
I may not be able to look at these PRs in detail today, but should have time this weekend.

@codecov-io
Copy link

codecov-io commented Oct 30, 2020

Codecov Report

Merging #1238 into master will decrease coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1238      +/-   ##
============================================
- Coverage     94.25%   93.76%   -0.50%     
- Complexity      455      458       +3     
============================================
  Files             2        2              
  Lines          6689     6753      +64     
  Branches       1799     1820      +21     
============================================
+ Hits           6305     6332      +27     
- Misses          106      128      +22     
- Partials        278      293      +15     
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 93.57% <0.00%> (-0.53%) 317.00% <0.00%> (+3.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d83fc4...56c0f4e. Read the comment docs.

@remkop remkop merged commit fd0ac35 into remkop:master Oct 30, 2020
@remkop remkop linked an issue Oct 30, 2020 that may be closed by this pull request
remkop added a commit that referenced this pull request Oct 30, 2020
@remkop remkop added this to the 4.6 milestone Oct 30, 2020
@remkop
Copy link
Owner

remkop commented Oct 30, 2020

Merged and published the rendered HTML.
I reordered sections so that the Quarkus section now follows the Micronaut section, and the CDI 2.0 section comes last.

Thank you for the contribution!

@deining deining deleted the quarkus-example branch October 31, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: update DI section on Quarkus
3 participants