Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1291] build.gradle for 'picocli-shell-jline3' submodule is changed: Gradle configuration is switched (from 'implementation' to 'api') for 'org.jline:jline' dependency #1292

Merged
merged 1 commit into from
Jan 3, 2021
Merged

[#1291] build.gradle for 'picocli-shell-jline3' submodule is changed: Gradle configuration is switched (from 'implementation' to 'api') for 'org.jline:jline' dependency #1292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion picocli-shell-jline3/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ targetCompatibility = 1.8

dependencies {
implementation rootProject
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we change this to api too?

Copy link
Contributor Author

@dejan2609 dejan2609 Jan 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx for a review @remal ! I will push another commit for picocli-spring-boot-starter tomorrow (and hopefully all these commits will be squashed into one if/when this gets merged into master).

As for a rootProject... To be honest: this is the first that I see this Gradle directive used as a dependency (I presume that it references code/dependency from root/src/ (that somehow didn't find its way into some separate submodule).

⏩ Going further: if we compare transitive dependencies for picocli-shell-jline3 recent versions (4.5.2 vs. 4.6.0):

we will found out that Maven scope changed from compile to runtime for these three dependencies:

  1. info.picocli:picocli (root project, mentioned above)
  2. org.jline:jline (https://github.com/jline/jline3/blob/master/jline/pom.xml)
  3. org.jline:jline-console (https://github.com/jline/jline3/blob/master/console/pom.xml)

It seems that Gradle configuration for all of those three dependencies should be changed from implementation to api in order to re-introduce Maven scope compile (when those dependencies are used transitively, that is).

I will have to sleep on this 😴

implementation "org.jline:jline:$jline3Version"
api "org.jline:jline:$jline3Version"
implementation "org.jline:jline-console:$jline3Version"
testImplementation "junit:junit:$junitVersion"
}
Expand Down