Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad encoding when creating default PrintWriter #1321

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

charphi
Copy link
Contributor

@charphi charphi commented Feb 3, 2021

Fix #1320

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #1321 (9da5d21) into master (ac0dcea) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1321   +/-   ##
=========================================
  Coverage     93.77%   93.77%           
- Complexity      469      474    +5     
=========================================
  Files             2        2           
  Lines          6952     6957    +5     
  Branches       1865     1867    +2     
=========================================
+ Hits           6519     6524    +5     
  Misses          146      146           
  Partials        287      287           
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 93.60% <100.00%> (+<0.01%) 330.00 <12.00> (+5.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac0dcea...9da5d21. Read the comment docs.

@remkop remkop added this to the 4.7 milestone Feb 4, 2021
@remkop remkop added the theme: shell An issue or change related to interactive (JLine) applications label Feb 4, 2021
@remkop remkop merged commit 14fbb63 into remkop:master Feb 4, 2021
remkop added a commit that referenced this pull request Feb 4, 2021
@remkop
Copy link
Owner

remkop commented Feb 4, 2021

Thanks for the PR!
Merged and documented in the release notes.

@remkop remkop modified the milestones: 4.7, 4.6.2 Feb 23, 2021
MarkoMackic pushed a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
…of `sun.stdout.encoding` and `sun.stderr.encoding`"

This reverts commit f82fe75.
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
…of `sun.stdout.encoding` and `sun.stderr.encoding`"

This reverts commit f82fe75.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: shell An issue or change related to interactive (JLine) applications type: bug 🐛 type: enhancement ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad encoding on default picocli.CommandLine#getOut and picocli.CommandLine#getErr
2 participants