Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix incorrect version in MANIFEST.MF #1327

Merged
merged 1 commit into from
Feb 20, 2021

Conversation

Fiouz
Copy link
Contributor

@Fiouz Fiouz commented Feb 20, 2021

Fix wrong Implementation-Version and Specification-Version introduced by bdf774e such as (notice the task ':jar' property 'archiveVersion'):

Implementation-Version: task ':jar' property 'archiveVersion'
Import-Package: groovy.lang
Main-Class: picocli.AutoComplete
Multi-Release: true
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.5))"
Specification-Title: picocli
Specification-Vendor: Remko Popma
Specification-Version: task ':jar' property 'archiveVersion'

(from https://repo1.maven.org/maven2/info/picocli/picocli/4.6.1/picocli-4.6.1.jar / META-INF/MANIFEST.MF)

@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #1327 (c003ee6) into master (e5bce48) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1327   +/-   ##
=========================================
  Coverage     93.77%   93.77%           
  Complexity      474      474           
=========================================
  Files             2        2           
  Lines          6957     6957           
  Branches       1867     1867           
=========================================
  Hits           6524     6524           
  Misses          146      146           
  Partials        287      287           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5bce48...c003ee6. Read the comment docs.

@remkop remkop added this to the 4.7 milestone Feb 20, 2021
@remkop remkop merged commit 5d0848f into remkop:master Feb 20, 2021
remkop added a commit that referenced this pull request Feb 20, 2021
@remkop
Copy link
Owner

remkop commented Feb 20, 2021

Merged. Thank you for the pull request!

@Fiouz Fiouz deleted the fix_manifest_version branch February 21, 2021 03:30
@remkop remkop modified the milestones: 4.7, 4.6.2 Feb 23, 2021
MarkoMackic pushed a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants