Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation, chapter 'Testing environment variables:': add Kotlin test sample #1344

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Documentation, chapter 'Testing environment variables:': add Kotlin test sample #1344

merged 1 commit into from
Mar 18, 2021

Conversation

deining
Copy link
Contributor

@deining deining commented Mar 14, 2021

This PR adds Kotlin test samples for testing envorinment variables to the manual. It also fixes a compilation issue and two other minor quirks for the existing Java samples.

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #1344 (26e4db5) into master (7438ef4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1344   +/-   ##
=========================================
  Coverage     93.76%   93.76%           
  Complexity      474      474           
=========================================
  Files             2        2           
  Lines          6961     6961           
  Branches       1869     1869           
=========================================
  Hits           6527     6527           
  Misses          147      147           
  Partials        287      287           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7438ef4...26e4db5. Read the comment docs.

@remkop remkop merged commit 5882ea5 into remkop:master Mar 18, 2021
remkop added a commit that referenced this pull request Mar 18, 2021
@remkop remkop added this to the 4.6.2 milestone Mar 18, 2021
@remkop
Copy link
Owner

remkop commented Mar 18, 2021

Merged. Sorry for the delay, this dropped below my inbox horizon...
Thank you again for the contribution!

MarkoMackic pushed a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
…ing environment variables'"

This reverts commit f95ddb4.
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
…ing environment variables'"

This reverts commit f95ddb4.
@deining deining deleted the test_envvar branch February 16, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants