Fix #1351 #1362
Merged
Fix #1351 #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1362 +/- ##
============================================
- Coverage 93.76% 93.75% -0.01%
Complexity 474 474
============================================
Files 2 2
Lines 6961 6968 +7
Branches 1869 1872 +3
============================================
+ Hits 6527 6533 +6
Misses 147 147
- Partials 287 288 +1
Continue to review full report at Codecov.
|
remkop
requested changes
Apr 21, 2021
|
Hi @remkop, thanks for your kind advice. We have modified the codes according to your suggestions. |
remkop
requested changes
Apr 21, 2021
remkop
added
type: enhancement ✨
theme: usagehelp
|
Merged. Thank you for the contribution! 👍 |
|
Thanks @remkop for merging. |
remkop
added a commit
that referenced
this pull request
Apr 21, 2021
|
I updated the release notes now. Thank you again for the contribution! |
MarkoMackic
pushed a commit
to MarkoMackic/picocli
that referenced
this pull request
Oct 17, 2021
…ates` optimization
MarkoMackic
added a commit
to MarkoMackic/picocli
that referenced
this pull request
Oct 17, 2021
…onCandidates` optimization" This reverts commit 05d952d.
MarkoMackic
added a commit
to MarkoMackic/picocli
that referenced
this pull request
Oct 17, 2021
…onCandidates` optimization" This reverts commit 05d952d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm with @sustc11810424 and @Lanninger08 to fix issue #1351.
If we've understood it right, we just need to avoid iterating through
completionCandidatesunnecessarily by first checking any existence of${COMPLETION-CANDIDATES}.A very simple solution with a test case is presented in the PR.