Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whou/fix window to unix newline #1431

Closed

Conversation

wenhoujx
Copy link

fix a bunch of ^M window newline chars.

@wenhoujx wenhoujx force-pushed the whou/fix-window-to-unix-newline branch from e1d6439 to 24362fb Compare September 13, 2021 16:28
@wenhoujx wenhoujx mentioned this pull request Sep 13, 2021
@remkop remkop closed this in 43b8e4e Sep 28, 2021
@remkop
Copy link
Owner

remkop commented Sep 28, 2021

Newlines for HTML should be automatically converted from CRLF to LF when committing to git.
I updated the .gitattributes file accordingly.

Thank you for pointing this out!

@remkop remkop added this to the 4.6.2 milestone Sep 28, 2021
@wenhoujx
Copy link
Author

oh, TIL. thanks!

MarkoMackic pushed a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
…lude HTML files to convert CRLF to LF."

This reverts commit 1455fae.
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
…lude HTML files to convert CRLF to LF."

This reverts commit 1455fae.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants