Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#148 Fix infinite loop when word is too large for column #150

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

smartboyathome
Copy link

@smartboyathome smartboyathome commented Jul 19, 2017

Splits the word naively at the column boundary. Don't know if this is the best way but seems to pass all the tests, including the one I made to repro this issue.

Fixes #148

Splits the word naively at the column boundary.
@codecov-io
Copy link

codecov-io commented Jul 19, 2017

Codecov Report

Merging #150 into master will increase coverage by 0.41%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #150      +/-   ##
============================================
+ Coverage        91%   91.41%   +0.41%     
- Complexity       50       53       +3     
============================================
  Files             1        1              
  Lines          1256     1258       +2     
  Branches        320      321       +1     
============================================
+ Hits           1143     1150       +7     
+ Misses           46       42       -4     
+ Partials         67       66       -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 91.41% <50%> (+0.41%) 53 <0> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f2a58...feabd69. Read the comment docs.

@remkop
Copy link
Owner

remkop commented Jul 19, 2017

Thanks a lot for the PR! I will review tonight when I get home from work.

@remkop remkop merged commit feabd69 into remkop:master Jul 21, 2017
@remkop
Copy link
Owner

remkop commented Jul 21, 2017

Thank you for your pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants