CommandLine cleanup #1568
Merged
CommandLine cleanup #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atedMembers because it works on both fields & methods
…<?>> instead of Stack<Class<?>> because it's only used for contains Renamed originalHierarchy local variable as fullHierarchySet because the former sounds as if the hierarchy was (or is somehow being) changed, but it's not
|
The tests may be failing because of another PR I merger earlier today (#1080)... need to take a look. May need to revert that. |
|
The build failure does come from that PR, and is in |
remkop
approved these changes
Feb 8, 2022
|
I ignored the failing test now. |
|
Thanks |
|
Are you waiting to merge until the build error is fixed? |
|
Just caught up with other stuff. I hope to merge and do a release later today. |
|
Cool. No rush. Just wanted to ensure that I didn't need to make any more modifications. |
|
Just submitted a gradle bump to 7.4 PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanup in
CommandLine