[https://github.com/remkop/picocli/issues/1696] Fix asciidoc output for nested ArgGroups #1697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1696, this fix utilizes the
ArgGroupSpec#allOptionsNested()
andArgGroupSpec#allPositionalParametersNested()
to list options under the proper group in the asciidoc output.Note that this fix may cause an option to be shown multiple times in the output when nesting multiple ArgGroups with headings. For example, if an ArgGroup with heading
Top
contains another ArgGroup with headingNested
, then any options defined in theNested
group will be listed under bothTop
andNested
groups in the asciidoc output. Not sure whether this is a valid/common use case though, and functionally bothArgGroups
contain that option (directly or indirectly), so it's not even really wrong.For reference, following is a sample command class and corresponding asciidoc output when using this fix.
Test class:
Asciidoc output: