Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[https://github.com/remkop/picocli/issues/1706] Resolve messages against parent resource bundles with updated i18n unit tests #1710

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

MikeTheSnowman
Copy link
Contributor

[https://github.com//issues/1706] Resolve messages against parent resource bundles. Also provided are updated i18n unit tests.

@remkop
Copy link
Owner

remkop commented Jun 16, 2022

Thank you for the contribution!
I won't be able to review until after this weekend.

Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally could make time to look at this. Sorry for the delay.
Overall, this looks great, thank you very much!
I have some minor feedback about the coding style (whitespace), can you take a look at that?

src/main/java/picocli/CommandLine.java Show resolved Hide resolved
@remkop remkop added this to the 4.7 milestone Jun 24, 2022
@remkop remkop added type: enhancement ✨ theme: usagehelp An issue or change related to the usage help message labels Jun 24, 2022
@remkop remkop linked an issue Jun 27, 2022 that may be closed by this pull request
@MikeTheSnowman MikeTheSnowman requested a review from remkop June 28, 2022 01:04
Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found more whitespace style issues. Sorry to be nitpicking, but I would prefer to keep the code style consistent. 😓
Can you take a look?

src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
@remkop remkop merged commit 295b3d3 into remkop:main Jun 28, 2022
@remkop
Copy link
Owner

remkop commented Jun 28, 2022

Merged. Thank you for the contribution! I will update the release notes when I get to my PC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: usagehelp An issue or change related to the usage help message type: enhancement ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option descriptions not read from parent command resource bundle
3 participants