Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 1713] Support optional booleans in annotation processor #1714

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

nineinchnick
Copy link
Contributor

Fixes #1713

@nineinchnick nineinchnick changed the title Support optional booleans in annotation processor [Issue 1713] Support optional booleans in annotation processor Jun 20, 2022
@remkop remkop added type: enhancement ✨ theme: annotation-proc An issue or change related to the annotation processor labels Jun 20, 2022
@remkop remkop added this to the 4.7 milestone Jun 20, 2022
@nineinchnick
Copy link
Contributor Author

@remkop can you retry the CI one more time? Maybe it had something to do with the latest CloudFlare issue.

@remkop remkop merged commit b0a23ce into remkop:main Jun 23, 2022
@remkop
Copy link
Owner

remkop commented Jun 23, 2022

Merged. Thank you for the contribution!

remkop added a commit that referenced this pull request Jun 23, 2022
@nineinchnick nineinchnick deleted the annot-proc-optional-bool branch August 18, 2022 15:03
@nineinchnick
Copy link
Contributor Author

@remkop do you have any ETA for 4.7? I'm eager to use this to build a native binary for the Trino CLI

@remkop
Copy link
Owner

remkop commented Aug 18, 2022

Hi @nineinchnick, I will probably move some of the items that are currently in scope for 4.7 to a later release.

That said, there are currently 4 tickets of type:bug (actually 5 but one is not reproducible), and one PR that I want to look at and resolve before releasing 4.7.

I currently don't have much time to work on picocli, so I cannot give any date estimates.
Hopefully this calendar year! 😅

@remkop
Copy link
Owner

remkop commented Aug 18, 2022

@nineinchnick and the Trino CLI looks great! Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: annotation-proc An issue or change related to the annotation processor type: enhancement ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Negatable Optional<Boolean> not recognized when annotation processor is enabled.
2 participants