Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue: #1708] Including log info for invalid values scenario #1723

Merged
merged 3 commits into from
Jun 27, 2022
Merged

[Issue: #1708] Including log info for invalid values scenario #1723

merged 3 commits into from
Jun 27, 2022

Conversation

fabio-franco
Copy link
Contributor

In this pr it was included some log info for invalid scenarios from this issue: #1708

@fabio-franco fabio-franco changed the title including log info for invalid values scenario [Issue: #1708] Including log info for invalid values scenario Jun 26, 2022
remkop
remkop requested changes Jun 26, 2022
View reviewed changes
Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to have separate log messages for when the longOptionsMaxWidth is too small and for when it is too big.
That will allow us to give much clearer feedback to end users.
Can you take a look?

src/main/java/picocli/CommandLine.java Show resolved Hide resolved
@remkop remkop added this to the 4.7 milestone Jun 26, 2022
@remkop remkop added type: enhancement ✨ theme: usagehelp An issue or change related to the usage help message labels Jun 26, 2022
@remkop remkop self-requested a review June 27, 2022 06:21
@remkop remkop merged commit 132f1ab into remkop:main Jun 27, 2022
@remkop
Copy link
Owner

remkop commented Jun 27, 2022

Merged. Thank you for the contribution! 🙏

remkop added a commit that referenced this pull request Jun 27, 2022
@remkop
[#1708][#1712][#1723] update RELEASE-NOTES
47a3202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remkop remkop remkop approved these changes

Assignees
No one assigned
Labels
theme: usagehelp An issue or change related to the usage help message type: enhancement ✨
Projects
None yet
Milestone
4.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabio-franco @remkop