Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1767 - NPE on OptionSpec.getValue() (IScoped) #1802

Merged
merged 2 commits into from
Sep 11, 2022
Merged

Fix #1767 - NPE on OptionSpec.getValue() (IScoped) #1802

merged 2 commits into from
Sep 11, 2022

Conversation

rsenden
Copy link
Contributor

@rsenden rsenden commented Sep 7, 2022

This PR fixes #1767, based on the IScoped approach discussed in the issue

remkop
remkop requested changes Sep 9, 2022
View reviewed changes
Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
I do prefer this approach to the IGetterAccessChecker alternative approach in #1801

I have some requests for minor changes, can you take a look?

src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
@remkop remkop added this to the 4.7 milestone Sep 9, 2022
@remkop remkop added type: enhancement ✨ type: API 🔌 theme: arg-group An issue or change related to argument groups theme: parser An issue or change related to the parser labels Sep 9, 2022
@remkop remkop merged commit fbccfe4 into remkop:main Sep 11, 2022
remkop added a commit that referenced this pull request Sep 11, 2022
@remkop
[#1767][#1802] Update Release Notes
3ae5c3b 
* avoid NPE on `OptionSpec.getValue()`
* add `IScoped` internal API
@remkop
Copy link
Owner

remkop commented Sep 11, 2022

Merged. Thank you for the PR!

@remkop remkop mentioned this pull request Sep 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remkop remkop remkop approved these changes

Assignees
No one assigned
Labels
theme: arg-group An issue or change related to argument groups theme: parser An issue or change related to the parser type: API 🔌 type: enhancement ✨
Projects
None yet
Milestone
4.7
Development

Successfully merging this pull request may close these issues.

NPE on OptionSpec.getValue()
2 participants
@rsenden @remkop