-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize incremental builds and local build cache usage #1807
Conversation
jean-andre-gauthier
commented
Sep 9, 2022
- Optimize incremental builds
- Replace copyJavadocDocFiles workaround by javadoc sourcepath
- Specify output dir in generateManpageAsciiDoc task
- Specify output file in generateVersionTxt task
- Optimize local build cache usage
- Add normalization for manifest.mf to ignore Bnd-LastModified attribute
- Add normalization for version.txt in 'picocli-examplesto ignoreBuildtime` property
- Optimize incremental builds - Replace copyJavadocDocFiles workaround by javadoc sourcepath - Specify output dir in generateManpageAsciiDoc task - Specify output file in generateVersionTxt task - Optimize local build cache usage - Add normalization for manifest.mf to ignore Bnd-LastModified attribute - Add normalization for version.txt in 'picocli-examplesto ignoreBuildtime` property
@runningcode FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
gradle.properties
Outdated
@@ -0,0 +1 @@ | |||
org.gradle.caching = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't commit this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this pull request!
Overall, looks good.
I see @runningcode already added a comment on the change to gradle.properties
about not disabling gradle caching.
Can you make that change, or otherwise argue the case of why this change should be included?
Thanks very much for the review, I've removed |
Merged. Thank you for the pull request! |
Optimize incremental builds and local build cache usage