Optimize incremental builds and local build cache usage #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jean-andre-gauthier
commented
Sep 9, 2022
jean-andre-gauthier
commented
- Optimize incremental builds
- Replace copyJavadocDocFiles workaround by javadoc sourcepath
- Specify output dir in generateManpageAsciiDoc task
- Specify output file in generateVersionTxt task
- Optimize local build cache usage
- Add normalization for manifest.mf to ignore Bnd-LastModified attribute
- Add normalization for version.txt in 'picocli-examplesto ignoreBuildtime` property
- Optimize incremental builds - Replace copyJavadocDocFiles workaround by javadoc sourcepath - Specify output dir in generateManpageAsciiDoc task - Specify output file in generateVersionTxt task - Optimize local build cache usage - Add normalization for manifest.mf to ignore Bnd-LastModified attribute - Add normalization for version.txt in 'picocli-examplesto ignoreBuildtime` property
|
@runningcode FYI |
runningcode
previously approved these changes
Sep 9, 2022
gradle.properties
Outdated
| @@ -0,0 +1 @@ | |||
| org.gradle.caching = false | |||
remkop
requested changes
Sep 11, 2022
There was a problem hiding this comment.
Thank you for this pull request!
Overall, looks good.
I see @runningcode already added a comment on the change to gradle.properties about not disabling gradle caching.
Can you make that change, or otherwise argue the case of why this change should be included?
remkop
added
type: enhancement ✨
theme: build
|
Thanks very much for the review, I've removed |
remkop
approved these changes
Sep 12, 2022
|
Merged. Thank you for the pull request! |
remkop
added a commit
that referenced
this pull request
Sep 12, 2022
Optimize incremental builds and local build cache usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.