Document System.exit usage #1857
Conversation
Resolves #1855 Signed-off-by: Tadaya Tsuyukubo <tadaya@ttddyy.net>
docs/index.adoc
Outdated
| The `System.exit` call finishes maven process bypassing the rest of the maven steps including its error handlings. | ||
|
|
||
| In picocli, any exceptions thrown during the `CommandLine.execute` method are captured, printed, and converted to an exit code. | ||
| You can check the exit code and perform an appropriate action, such as throwing an exception, instead of calling `System.exit`. |
There was a problem hiding this comment.
This looks strange: you are correct that picocli captures any exceptions thrown during the CommandLine.execute method. That is the difference with the CommandLine.parseArgs method. If an application wants to throw an exception when a problem occurs, it should just use parseArgs.
It would be strange to first capture an exception, convert to an error code, and then use that error code to throw another, less informative, exception...
The manual should not recommend that but instead should recommend using parseArgs.
There was a problem hiding this comment.
changed to recommend parseArgs and linked to the 9.7. DIY Command Execution section
|
Thank you! |
|
Thank you for the contribution! |
Documentation for a usecase not to use
System.exit.Resolves #1855