Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't load resource bundles during annotation processing (fixes #1876) #1878

Merged
merged 3 commits into from
Dec 20, 2022
Merged

Don't load resource bundles during annotation processing (fixes #1876) #1878

merged 3 commits into from
Dec 20, 2022

Conversation

rsenden
Copy link
Contributor

@rsenden rsenden commented Nov 23, 2022

This PR fixes #1876

remkop
remkop requested changes Nov 30, 2022
View reviewed changes
Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for responding late.
I added some requests for changes, can you take a look?

I realized that this solution means a public API change, and strictly following semantic versioning means that this fix would have to go in a 4.8 release. I was hoping to do some pure bugfix releases (4.7.1 etc).
On the other hand, the new method is technically public API but it is also internal API, not intended to be invoked by applications, so perhaps breaking semantic versioning can be forgiven... Hm... Still thinking of how to deal with this. 😅

src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
@remkop remkop added this to the 4.7.1 milestone Dec 16, 2022
@remkop remkop added type: bug 🐛 type: API 🔌 theme: annotation-proc An issue or change related to the annotation processor labels Dec 16, 2022
@remkop
Copy link
Owner

remkop commented Dec 16, 2022

After thinking about this some more, since this is internal API that is not intended to be used by applications authors, I don't think this requires a 4.8 release so I will include this in 4.7.1. Can you take a look at the requested changes?

@remkop remkop merged commit fa994b2 into remkop:main Dec 20, 2022
@remkop
Copy link
Owner

remkop commented Dec 20, 2022

Merged. Thank you for the contribution!

@remkop remkop mentioned this pull request Feb 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remkop remkop remkop approved these changes

Assignees
No one assigned
Labels
theme: annotation-proc An issue or change related to the annotation processor type: API 🔌 type: bug 🐛
Projects
None yet
Milestone
4.7.1
Development

Successfully merging this pull request may close these issues.

Picocli codegen 4.7.0 breaks our build
2 participants
@rsenden @remkop