Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update option rendering (fixes #1886) #1896

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Update option rendering (fixes #1886) #1896

merged 1 commit into from
Dec 20, 2022

Conversation

rsenden
Copy link
Contributor

@rsenden rsenden commented Dec 16, 2022

No description provided.

@remkop remkop linked an issue Dec 17, 2022 that may be closed by this pull request
AsciiDoc generator doesn't output any options if all options are in ArgGroups #1886
Closed
@remkop remkop added the theme: codegen An issue or change related to the picocli-codegen module label Dec 17, 2022
@remkop remkop added this to the 4.7.1 milestone Dec 17, 2022
@remkop remkop merged commit fc8aa03 into remkop:main Dec 20, 2022
@remkop
Copy link
Owner

remkop commented Dec 20, 2022

Merged. Thank you for the contribution!

@remkop remkop mentioned this pull request Jan 24, 2023
Closed
5 tasks
@remkop
Copy link
Owner

remkop commented Jan 24, 2023

Hi @rsenden, while looking at fixing the CI/CD pipeline (#1930), I noted that ManPageGeneratorTest now has 3 failing tests (testEndOfOptionsWithoutOptions - line 307, testNamelessCommand line 489 and testHiddenOptions line 242). I believe this is related to the changes for this PR.

Can I ask you to take a look at these test failures? 😅

remkop added a commit that referenced this pull request Jan 24, 2023
@remkop
[#1930] ignore #1896 related broken tests for now
8d6419c
@MikeTheSnowman
Copy link
Contributor

Hey @remkop, @rsenden has asked me to have a look at the tests that you pointed out. I've just now started looking things, but it's a bit late where I'm at. I'll try to produce something to address the failing tests in next day. Is that okay with you?

@remkop
Copy link
Owner

remkop commented Jan 24, 2023

Sure no problem! Thank you for helping out!

@remkop
Copy link
Owner

remkop commented Jan 27, 2023

@wtfacoconut Did you have a chance to look at this?
I am thinking to do a 4.7.1 release in the next few days, would be great to include your tests. 😅

@MikeTheSnowman
Copy link
Contributor

@remkop . Sorry for the delay. Some family matters came up yesterday. I'll respond back with a few questions/comments in issue #1930 .

@remkop
Copy link
Owner

remkop commented Jan 27, 2023

No worries! Family first! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remkop remkop remkop approved these changes

Assignees
No one assigned
Labels
theme: codegen An issue or change related to the picocli-codegen module type: bug 🐛 type: doc 📘
Projects
None yet
Milestone
4.7.1
Development

Successfully merging this pull request may close these issues.

AsciiDoc generator doesn't output any options if all options are in ArgGroups
3 participants
@rsenden @remkop @MikeTheSnowman