Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed isJansiConsoleInstalled performance issue #1976

Merged
merged 8 commits into from
Mar 24, 2023
Merged

Fixed isJansiConsoleInstalled performance issue #1976

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89e0382
Fixed isJansiConsoleInstalled performance issue
ChrisTrenkamp Mar 19, 2023
2400268
Fixed failing test for Ansi.enabled()
ChrisTrenkamp Mar 20, 2023
a28578e
Fixed unexpected Ansi result in
ChrisTrenkamp Mar 20, 2023
a8edda3
Fixed comment.
ChrisTrenkamp Mar 20, 2023
7ed559c
Fixed the rest of the failing test cases.
ChrisTrenkamp Mar 20, 2023
446d79b
Merge branch 'main' into jansi-console-cache
remkop Mar 24, 2023
842f517
Merge branch 'main' into jansi-console-cache
remkop Mar 24, 2023
c4ed052
Merge branch 'main' into jansi-console-cache
remkop Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/picocli/CommandLine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17805,7 +17805,14 @@ static boolean ansiPossible() {
if (!isTTY() && !isPseudoTTY()) { return false; }
return hintEnabled() || !isWindows() || isXterm() || isCygwin() || hasOsType();
}
/** Cache the result for isJansiConsoleInstalled so it doesn't repeatedly
* call Class#forName, which can cause performance issues. */
static Boolean jansiConsole;
static boolean isJansiConsoleInstalled() {
if (jansiConsole == null) { jansiConsole = calcIsJansiConsoleInstalled(); }
return jansiConsole;
}
static boolean calcIsJansiConsoleInstalled() {
try {
// first check if JANSI was explicitly disabled _without loading any JANSI classes_:
// see https://github.com/remkop/picocli/issues/1106
Expand Down