IAnnotatedElementProvider to Access to ArgSpec/OptionSpec setter/getter field/method #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nasdanika CLI operates on top of picocli. One of its features is generation of HTML documentation site and support of extended documentation (https://docs.nasdanika.org/core/cli/index.html#extended-documentation) Currently this functionality works with CommandSpec by accessing user object. To extend it to arguments and options it is necessary to be able to access underlying fields/methods. This commit introduces IReflector interface implemented by FieldBinding and Method Binding.
remkop
requested changes
Jul 30, 2024
|
|
||
| /** | ||
| * Provides access to the underlying {@link AnnotatedElement}. | ||
| */ |
There was a problem hiding this comment.
Can you add a @since 4.8.0 javadoc tag here please?
| } | ||
|
|
||
| @Test | ||
| public void testFieldAccess() throws Exception { |
There was a problem hiding this comment.
Can you also add a test for annotated method access?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces IAnnotatedElementProvider interface implemented by FieldBinding and MethodBinding.
This allows to access underlying fields/methods of parameters and options.
See also issue #2325.