Various improvements to default values #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… same, all features are options and must be enabled explicitely): - bugfix: Default values couldn't be read from non-public fields (was missing setAccessible()) - mask default value: This allows to specify a mask string in @options that will be displayed instead of any existing default value (will not be displayed if no default value exists) - notRequiredWithDefault in @command allows a default value in a required field to become non-required - refreshDefaultValues() added to CommandLine Unit tests for all features included
…(getDefaultValue(scope, field)); can go back to being in it's original location
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
============================================
- Coverage 90.21% 89.98% -0.23%
- Complexity 165 173 +8
============================================
Files 4 4
Lines 2350 2396 +46
Branches 591 602 +11
============================================
+ Hits 2120 2156 +36
- Misses 102 107 +5
- Partials 128 133 +5
Continue to review full report at Codecov.
|
This was referenced Jan 16, 2018
|
Implemented, see comment on #261. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to default values (standard behavior remains the same, all features are options and must be enabled explicitely):
Unit tests for all features included